heyihong commented on code in PR #53681:
URL: https://github.com/apache/spark/pull/53681#discussion_r2662896117
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/QueryPlan.scala:
##########
@@ -621,12 +621,14 @@ abstract class QueryPlan[PlanType <: QueryPlan[PlanType]]
/**
* A variant of [[foreach]] which considers plan nodes inside subqueries as
well.
+ * The traverse order is subqueries first and then children.
Review Comment:
I added this comment because the traversal order can be confusing, given the
implementation and [your previous
comment](https://github.com/apache/spark/pull/53637#discussion_r2658955697) (we
already assume traversal starts at the current node). On second thought, I
think it makes more sense to mention f's invoke order instead of the traversing
order, which is first itself, then its subqueries, and then its children.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
