szehon-ho commented on code in PR #53227: URL: https://github.com/apache/spark/pull/53227#discussion_r2663010547
########## sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/util/geo/GeometryModel.java: ########## @@ -0,0 +1,182 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.spark.sql.catalyst.util.geo; + +/** + * Abstract base class for specific geometry types (Point, LineString, Polygon, etc.). + * This class provides common functionality needed by geometry subclasses. + */ +public abstract class GeometryModel { + + /** GeometryModel internal implementation. */ + + // Geometry type and SRID information + protected GeoTypeId typeId; + protected int sridValue; + + /** GeometryModel constants. */ + + // The default SRID value for GEOMETRY values. + static int DEFAULT_SRID = 0; Review Comment: There is a case of Geometry.fromWKB without srid argument. Removed in favor of the existing Geometry.DEFAULT_SRID constant. ########## sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/util/geo/Point.java: ########## @@ -0,0 +1,126 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.spark.sql.catalyst.util.geo; + +import java.util.Arrays; + +/** + * Represents a point geometry with coordinates. + */ +class Point extends GeometryModel { + private final double[] coordinates; + private final boolean is_Empty; Review Comment: Changed, thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
