dtenedor opened a new pull request, #53702: URL: https://github.com/apache/spark/pull/53702
### What changes were proposed in this pull request? This PR improves error messages from the new KLL quantile sketch functions added in https://github.com/apache/spark/pull/52800. ### Why are the changes needed? The previous error messages reported internal DataSketches library state which was not meaningful for end users of the SQL/DF functions in Apache Spark. ### Does this PR introduce _any_ user-facing change? Yes, error messages are improved. For example, before this change, we observed the following: ``` SELECT kll_sketch_get_rank_bigint(agg, 5) AS wrong_type FROM ( SELECT kll_sketch_agg_float(col1) AS agg FROM t_float_1_5_through_7_11 ) > For function `kll_sketch_get_rank_bigint`, invalid KLL sketch binary data: reqOffset: 40, reqLength: 56, (reqOff + reqLen): 96, allocSize: 60" ``` Now the error message becomes: ``` > "Invalid call to `kll_sketch_get_rank_bigint`; only valid KLL sketch buffers are supported as inputs (such as those produced by the `kll_sketch_agg` function)." ``` ### How was this patch tested? This PR updates golden file test coverage to show the improved error messages. ### Was this patch authored or co-authored using generative AI tooling? No. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
