gaogaotiantian commented on code in PR #53099:
URL: https://github.com/apache/spark/pull/53099#discussion_r2666442311


##########
python/pyspark/sql/tests/streaming/test_streaming_foreach_batch.py:
##########
@@ -81,8 +81,6 @@ def collectBatch(df, id):
         except StreamingQueryException as e:
             err_msg = str(e)
             self.assertTrue("this should fail" in err_msg)
-            # check for foreachBatch error class
-            self.assertTrue("FOREACH_BATCH_USER_FUNCTION_ERROR" in err_msg)

Review Comment:
   Overall it's pretty similar. Before `PythonException` is not a 
`SparkThrowable` so I think streaming team wrapped the exception. Now it is a 
standard `SparkThrowable` so it can be raised directly to Python. The SQLSTATE 
code is changed - all the `PythonException` has the same SQLSTATE for now - we 
plan to change that in the future so it's determined by the actual python 
exception. This is just the framework to make it happen.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to