gaogaotiantian commented on PR #53716: URL: https://github.com/apache/spark/pull/53716#issuecomment-3721269505
> IMO it feels weird to have pyproject.toml in root. pyspark is just one component of the entire repo. we can always add dev/ into the search path right? No that's not how all tools work. If all of our python code is in `python/`, we can put it in `python`, but that's not the case. We have python files (that we check) in other directories like `dev/`. It's quite common to put this kind of files in repo root - just because tools will find it as long as they are executed in repo. If we put it in `python/`, `ruff check` won't be able to pick it up when we run it at root. I think the overall direction is to make users use tools as natural as possible. For example, they can just do `pytest` and pick up all the options we pre-set. This is not possible when `pyproject.toml` lives in `dev`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
