zhengruifeng commented on code in PR #53718: URL: https://github.com/apache/spark/pull/53718#discussion_r2670544998
########## python/pyspark/tests/upstream/pyarrow/test_pyarrow_type_inference.py: ########## @@ -0,0 +1,529 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# + +import datetime +from decimal import Decimal +import unittest + +from pyspark.testing.utils import ( + have_pandas, + have_pyarrow, + pandas_requirement_message, + pyarrow_requirement_message, +) + + +# Test pa.array type inference for various input types. +# This test monitors the behavior of PyArrow's type inference to ensure +# PySpark's assumptions about PyArrow behavior remain valid across versions. +# +# Key input types tested: +# 1. nullable data (with None values) +# 2. plain Python instances (list, tuple, array) +# 3. pandas instances (pd.Series) +# 4. numpy instances (np.array) + + [email protected](not have_pyarrow, pyarrow_requirement_message) +class PyArrowTypeInferenceTests(unittest.TestCase): + """Test PyArrow's type inference behavior for pa.array.""" + + def test_nullable_data(self): Review Comment: > it would be harder to find the failed pair assertions supports error message like `self.assertEqual(a, b, f"{a} {b}")` > some of the cases need special comments the comments can be interleaved with codes ``` for value, expected_type in [ # comments ([None], pa.null()), # comments ... ]: ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
