HyukjinKwon commented on code in PR #53728:
URL: https://github.com/apache/spark/pull/53728#discussion_r2674048820
##########
dev/create-release/releaseutils.py:
##########
@@ -132,124 +106,24 @@ def get_commits(tag):
print(line)
sys.exit(1)
# Separate commit digest from the body
- # From the digest we extract the hash, author and the title
+ # From the digest we extract the hash and the title
# From the body, we extract the PR number and the github username
[commit_digest, commit_body] = commit.split(commit_end_marker)
- if commit_digest.count(field_end_marker) != 2:
+ if commit_digest.count(field_end_marker) != 1:
sys.exit("Unexpected format in commit: %s" % commit_digest)
- [_hash, author, title] = commit_digest.split(field_end_marker)
+ [_hash, title] = commit_digest.split(field_end_marker)
# The PR number and github username is in the commit message
# itself and cannot be accessed through any GitHub API
pr_number = None
+ github_username = None
Review Comment:
I think we should probably skip the case when github_username is not found.
99% cases `github_username` should be available but there are other cases like
removal of the account, co-authored commits who don't have github accounts, etc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
