longvu-db commented on code in PR #53732:
URL: https://github.com/apache/spark/pull/53732#discussion_r2675361733
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala:
##########
@@ -1249,27 +1249,50 @@ class Analyzer(
val partCols = partitionColumnNames(r.table)
validatePartitionSpec(partCols, i.partitionSpec)
+ val schemaEvolutionWriteOption: Map[String, String] =
+ if (i.withSchemaEvolution) Map("mergeSchema" -> "true") else
Map.empty
+
val staticPartitions =
i.partitionSpec.filter(_._2.isDefined).transform((_, v) => v.get)
val query = addStaticPartitionColumns(r,
projectByName.getOrElse(i.query), staticPartitions,
isByName)
if (!i.overwrite) {
if (isByName) {
- AppendData.byName(r, query)
+ AppendData.byName(
Review Comment:
@szehon-ho You mean we should add a flag `schemaEvolution` in place of
`writeOptions = schemaEvolutionWriteOption` in v2 Write nodes, and add the
`schemaEvolutionWriteOption` in
https://github.com/apache/spark/blob/master/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/v2Commands.scala#L61
if the `schemaEvolution` flag is enabled?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
