zhengruifeng commented on code in PR #53749:
URL: https://github.com/apache/spark/pull/53749#discussion_r2675885566


##########
python/pyspark/sql/connect/client/core.py:
##########
@@ -2125,26 +2125,22 @@ def _create_profile(self, profile: pb2.ResourceProfile) 
-> int:
         profile_id = properties["create_resource_profile_command_result"]
         return profile_id
 
-    def _delete_ml_cache(self, cache_ids: List[str], evict_only: bool = False) 
-> List[str]:
-        # try best to delete the cache
-        try:
-            if len(cache_ids) > 0:
+    def _delete_ml_cache(self, cache_ids: List[str], evict_only: bool = False) 
-> None:
+        if len(cache_ids) > 0:
+            try:
                 command = pb2.Command()
                 command.ml_command.delete.obj_refs.extend(
                     [pb2.ObjectRef(id=cache_id) for cache_id in cache_ids]
                 )
                 command.ml_command.delete.evict_only = evict_only
-                (_, properties, _) = self.execute_command(command)

Review Comment:
   `execute_command` is baed on ExecutePlanResponseReattachableIterator



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to