dongjoon-hyun commented on code in PR #437: URL: https://github.com/apache/spark-kubernetes-operator/pull/437#discussion_r2678303947
########## build-tools/helm/spark-kubernetes-operator/templates/pdb.yaml: ########## @@ -0,0 +1,29 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +{{- if gt (int .Values.operatorDeployment.replicas) 1 }} +--- +apiVersion: policy/v1 +kind: PodDisruptionBudget +metadata: + name: spark-apache-operator Review Comment: Maybe, we need something like `spark-kubernetes-operator-pdb-xxx`. Also, please double-check multiple instances across namespaces. Apache Spark Kubernetes Operator can be installed per namespace like the following official document. https://github.com/apache/spark-kubernetes-operator/blob/main/docs/operations.md#example ``` $ k get all -A NAMESPACE NAME READY STATUS RESTARTS AGE kube-system pod/coredns-66bc5c9577-bjd5d 1/1 Running 0 106m kube-system pod/coredns-66bc5c9577-mzgnr 1/1 Running 0 106m kube-system pod/etcd-docker-desktop 1/1 Running 16 106m kube-system pod/kube-apiserver-docker-desktop 1/1 Running 16 106m kube-system pod/kube-controller-manager-docker-desktop 1/1 Running 16 106m kube-system pod/kube-proxy-f77lm 1/1 Running 0 106m kube-system pod/kube-scheduler-docker-desktop 1/1 Running 16 106m kube-system pod/storage-provisioner 1/1 Running 0 106m kube-system pod/vpnkit-controller 1/1 Running 0 106m us-west-1 pod/spark-kubernetes-operator-5f9d958469-xr2cz 1/1 Running 0 30s us-west-2 pod/spark-kubernetes-operator-5f9d958469-5l6th 1/1 Running 0 15s NAMESPACE NAME TYPE CLUSTER-IP EXTERNAL-IP PORT(S) AGE default service/kubernetes ClusterIP 10.96.0.1 <none> 443/TCP 106m kube-system service/kube-dns ClusterIP 10.96.0.10 <none> 53/UDP,53/TCP,9153/TCP 106m NAMESPACE NAME DESIRED CURRENT READY UP-TO-DATE AVAILABLE NODE SELECTOR AGE kube-system daemonset.apps/kube-proxy 1 1 1 1 1 kubernetes.io/os=linux 106m NAMESPACE NAME READY UP-TO-DATE AVAILABLE AGE kube-system deployment.apps/coredns 2/2 2 2 106m us-west-1 deployment.apps/spark-kubernetes-operator 1/1 1 1 30s us-west-2 deployment.apps/spark-kubernetes-operator 1/1 1 1 15s NAMESPACE NAME DESIRED CURRENT READY AGE kube-system replicaset.apps/coredns-66bc5c9577 2 2 2 106m us-west-1 replicaset.apps/spark-kubernetes-operator-5f9d958469 1 1 1 30s us-west-2 replicaset.apps/spark-kubernetes-operator-5f9d958469 1 1 1 15s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
