Ngone51 commented on code in PR #53748:
URL: https://github.com/apache/spark/pull/53748#discussion_r2680654876
##########
core/src/main/java/org/apache/spark/memory/TaskMemoryManager.java:
##########
@@ -401,6 +401,7 @@ private MemoryBlock allocatePage(
logger.warn("Failed to allocate a page ({} bytes) for {} times, try
again.", e,
MDC.of(LogKeys.PAGE_SIZE, acquired),
MDC.of(LogKeys.NUM_RETRY, retryCount));
+ showMemoryUsage();
Review Comment:
I see. It looks like we don't have a maximum retry attempts for
`TaskMemoryManager.allocatePage()`.
@mridulm @AngersZhuuuu Do you think we should add a retry thredshold here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
