Github user rxin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/6718#discussion_r32090941
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala ---
    @@ -122,7 +122,7 @@ object functions {
        * @group agg_funcs
        * @since 1.3.0
        */
    -  def sum(e: Column): Column = Sum(e.expr)
    +  def sum(a: Column): Column = Sum(a.expr)
    --- End diff --
    
    actually after thinking about it more ... this breaks scala source 
compatibility. Do you mind switching back to "e" and just use "e" for 
everything? It might've meant "expression". 
    
    For the new ones, I'd use "expr".


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to