cloud-fan commented on PR #53658: URL: https://github.com/apache/spark/pull/53658#issuecomment-3743778967
Thinking more about it, seems the fundamental issue is: `BooleanSimplification` does two kinds of things which need different transform orders to be efficient: - Actual simplification that reduces the expression. bottom up transformation is more efficient here. - `Not` pushdown. top-down transformation is more efficient here. Shall we split this rule into two? The current improvement makes this rule quite complicated with interleaved bottom-up and top-down transformation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
