srielau commented on code in PR #53530: URL: https://github.com/apache/spark/pull/53530#discussion_r2686814184
########## sql/core/src/main/scala/org/apache/spark/sql/execution/command/v2/OpenCursorExec.scala: ########## @@ -0,0 +1,174 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.spark.sql.execution.command.v2 + +import org.apache.spark.sql.AnalysisException +import org.apache.spark.sql.catalyst.{InternalRow, SqlScriptingContextManager} +import org.apache.spark.sql.catalyst.expressions.{Attribute, Expression} +import org.apache.spark.sql.catalyst.plans.logical.LogicalPlan +import org.apache.spark.sql.classic.Dataset +import org.apache.spark.sql.execution.datasources.v2.LeafV2CommandExec +import org.apache.spark.sql.scripting.{CursorDeclared, CursorOpened} + +/** + * Physical plan node for opening cursors. + * + * Transitions cursor from Declared to Opened state by analyzing the query and binding parameters. + * Does not execute the query or create result iterator - that happens on first FETCH. + * + * @param cursor CursorReference resolved during analysis phase + * @param args Parameter expressions from USING clause (for parameterized cursors) + * @param paramNames Names for each parameter (empty string for positional parameters) + */ +case class OpenCursorExec( + cursor: Expression, + args: Seq[Expression] = Seq.empty, + paramNames: Seq[String] = Seq.empty) extends LeafV2CommandExec { + + override protected def run(): Seq[InternalRow] = { + // Extract CursorReference from the resolved cursor expression + val cursorRef = cursor.asInstanceOf[org.apache.spark.sql.catalyst.expressions.CursorReference] + + val scriptingContextManager = SqlScriptingContextManager.get() + .getOrElse(throw new AnalysisException( + errorClass = "CURSOR_OUTSIDE_SCRIPT", + messageParameters = Map("cursorName" -> cursorRef.sql))) + + val scriptingContext = scriptingContextManager.getContext + .asInstanceOf[org.apache.spark.sql.scripting.SqlScriptingExecutionContext] + + // Find cursor using normalized name from CursorReference + val cursorDefOpt: Option[org.apache.spark.sql.scripting.CursorDefinition] = + if (cursorRef.scopePath.nonEmpty) { + scriptingContext.currentFrame.findCursorInScope( + cursorRef.scopePath.head, cursorRef.normalizedName) + } else { + scriptingContext.currentFrame.findCursorByName(cursorRef.normalizedName) + }.asInstanceOf[Option[org.apache.spark.sql.scripting.CursorDefinition]] + val cursorDef = cursorDefOpt.getOrElse( + throw new AnalysisException( + errorClass = "CURSOR_NOT_FOUND", + messageParameters = Map("cursorName" -> cursorRef.sql))) + + // Get current cursor state and validate it's in Declared state + val currentState = scriptingContext.currentFrame.getCursorState( + cursorRef.normalizedName, + cursorRef.scopePath).getOrElse( + throw new AnalysisException( + errorClass = "CURSOR_NOT_FOUND", + messageParameters = Map("cursorName" -> cursorRef.sql))) + + val query = currentState match { + case CursorDeclared(q) => q + case _ => + throw new AnalysisException( + errorClass = "CURSOR_ALREADY_OPEN", + messageParameters = Map("cursorName" -> cursorRef.sql)) + } + + // Execute the query and get the analyzed plan + val analyzedQuery = if (args.nonEmpty) { + // Parameterized cursor: re-parse query text with bound parameters Review Comment: Well, not really parsing as such. as ANTLR need to drill past it. But we can avoid building the logical plan. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
