Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/6726#discussion_r32091890
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -164,13 +164,28 @@ class CodeGenContext {
def equalFunc(dataType: DataType): ((String, String) => String) =
dataType match {
case BinaryType => { case (eval1, eval2) =>
s"java.util.Arrays.equals($eval1, $eval2)" }
- case IntegerType | BooleanType | LongType | DoubleType | FloatType |
ShortType | ByteType =>
+ case IntegerType | BooleanType | LongType | DoubleType | FloatType |
ShortType | ByteType
+ | DateType =>
{ case (eval1, eval2) => s"$eval1 == $eval2" }
--- End diff --
we should remove the case here, i.e.
```
case IntegerType | BooleanType | LongType | DoubleType | FloatType |
ShortType | ByteType
| DateType =>
(eval1, eval2) => s"$eval1 == $eval2"
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
