yaooqinn commented on code in PR #53811:
URL: https://github.com/apache/spark/pull/53811#discussion_r2694193589
##########
sql/core/src/test/scala/org/apache/spark/sql/connector/DataSourceV2SQLSuite.scala:
##########
@@ -3244,14 +3244,16 @@ class DataSourceV2SQLSuiteV1Filter
val t3 = s"testcat.t$ts1"
val t4 = s"testcat.t$ts2"
- withTable(t3, t4) {
+ withTable(t3, t4, "t") {
sql(s"CREATE TABLE $t3 (id int) USING foo")
sql(s"CREATE TABLE $t4 (id int) USING foo")
+ sql(s"CREATE TABLE t (ts STRING) USING foo")
sql(s"INSERT INTO $t3 VALUES (5)")
sql(s"INSERT INTO $t3 VALUES (6)")
sql(s"INSERT INTO $t4 VALUES (7)")
sql(s"INSERT INTO $t4 VALUES (8)")
+ sql(s"INSERT INTO t VALUES ('2019-01-29 00:37:58')")
Review Comment:
how about we add a test here for the NULL case if we don't have yet?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
