zifeif2 commented on code in PR #53720:
URL: https://github.com/apache/spark/pull/53720#discussion_r2696211902
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/RocksDBFileManager.scala:
##########
@@ -375,6 +375,8 @@ class RocksDBFileManager(
createDfsRootDirIfNotExist()
// Since we cleared the local dir, we should also clear the local file
mapping
rocksDBFileMapping.clear()
+ // Set empty metrics since we're not loading any files from DFS
+ loadCheckpointMetrics = RocksDBFileManagerMetrics.EMPTY_METRICS
Review Comment:
Added this line to make sure that loadCheckpointMetrics is set correctly
when we are loading empty store cc @anishshri-db .
RocksDB will run `fileManagerMetrics =
fileManager.latestLoadCheckpointMetrics`, and `latestLoadCheckpointMetrics`
return `loadCheckpointMetrics`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]