dtenedor commented on code in PR #53823:
URL: https://github.com/apache/spark/pull/53823#discussion_r2699445532
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/datasketchesAggregates.scala:
##########
@@ -338,7 +338,8 @@ case class HllUnionAgg(
union.update(sketch)
Some(union)
} catch {
- case _: SketchesArgumentException | _: java.lang.Error =>
+ case _: SketchesArgumentException | _: java.lang.Error
Review Comment:
I thought about making it catch `java.lang.Exception` as well but decided to
try to enumerate the exceptions of interest for now. This is generally safer
practice to prevent us from ignoring something unrelated that could fail later.
But if this acts up again, we might have no choice but to update it thusly in
the future. We can monitor
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/datasketchesAggregates.scala:
##########
@@ -338,7 +338,8 @@ case class HllUnionAgg(
union.update(sketch)
Some(union)
} catch {
- case _: SketchesArgumentException | _: java.lang.Error =>
+ case _: SketchesArgumentException | _: java.lang.Error
Review Comment:
I thought about making it catch `java.lang.Exception` as well but decided to
try to enumerate the exceptions of interest for now. This is generally safer
practice to prevent us from ignoring something unrelated that could fail later.
But if this acts up again, we might have no choice but to update it thusly in
the future. We can monitor.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
