cloud-fan commented on code in PR #53761: URL: https://github.com/apache/spark/pull/53761#discussion_r2703291583
########## core/src/main/java/org/apache/spark/util/BestEffortLazyVal.java: ########## @@ -38,24 +41,37 @@ * href="https://docs.scala-lang.org/scala3/reference/changed-features/lazy-vals-init.html";>Lazy * Vals Initialization</a> for more details. */ -private[spark] class BestEffortLazyVal[T <: AnyRef]( - @volatile private[this] var compute: () => T) extends Serializable { +public class BestEffortLazyVal<T> implements Serializable { + private volatile Function0<T> compute; Review Comment: nit: check other java files in the same directory, Spark uses 2 spaces indentation -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
