cloud-fan commented on code in PR #53854:
URL: https://github.com/apache/spark/pull/53854#discussion_r2705322096
##########
sql/core/src/main/scala/org/apache/spark/sql/classic/SparkSession.scala:
##########
@@ -176,6 +176,29 @@ class SparkSession private(
existingSharedState.getOrElse(new SharedState(sparkContext,
initialSessionOptions))
}
+ /**
+ * SQL-specific key-value configurations.
+ *
+ * This is initialized before sessionState to avoid recursive access during
sessionState
+ * initialization when SQLConf.get is called.
+ */
+ @transient
+ lazy val sqlConf: SQLConf = {
Review Comment:
let's make it `private[sql]` for now to save trouble. It should be an
unstable public API, and Spark Connect should add shim.
##########
sql/core/src/main/scala/org/apache/spark/sql/classic/SparkSession.scala:
##########
@@ -176,6 +176,29 @@ class SparkSession private(
existingSharedState.getOrElse(new SharedState(sparkContext,
initialSessionOptions))
}
+ /**
+ * SQL-specific key-value configurations.
+ *
+ * This is initialized before sessionState to avoid recursive access during
sessionState
+ * initialization when SQLConf.get is called.
+ */
+ @transient
+ lazy val sqlConf: SQLConf = {
Review Comment:
```suggestion
private[sql] lazy val sqlConf: SQLConf = {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
