zhengruifeng commented on code in PR #53867:
URL: https://github.com/apache/spark/pull/53867#discussion_r2707467351
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/python/PythonArrowOutput.scala:
##########
@@ -250,6 +253,7 @@ abstract class BaseSliceArrowOutputProcessor(
prevVectors.foreach(_.close())
prevRoot.close()
}
+ super.close()
Review Comment:
based on my observation, this line is not necessary to fix this issue.
But I feel the subclasses should always call it to free 'vectors` and `root'
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
