peter-toth commented on code in PR #53859:
URL: https://github.com/apache/spark/pull/53859#discussion_r2707992946


##########
sql/core/src/main/scala/org/apache/spark/sql/execution/exchange/EnsureRequirements.scala:
##########
@@ -688,21 +691,40 @@ case class EnsureRequirements(
           replicatePartitions = replicatePartitions
         )
       )
+      newScan.copyTagsFrom(scan)

Review Comment:
   The changes here in `populateCommonPartitionInfo()` and 
`populateJoinKeyPositions()` are not needed for this PR, but it turned out that 
copying tags is necessary for the new `populateNoGroupingPartitionInfo()`, so 
it is better to copy tags here as well to fix possible hidden bugs.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to