sarutak opened a new pull request, #53870:
URL: https://github.com/apache/spark/pull/53870

   ### What changes were proposed in this pull request?
   This PR aims to fix a flaky test in `RpcIntegrationSuite`.
   Recently, `sendRpcWithStreamFailures` occasionally fails.
   https://github.com/apache/spark/actions/runs/21073107447/job/60608256322
   ```
   [error] Test 
org.apache.spark.network.RpcIntegrationSuite.sendRpcWithStreamFailures failed: 
org.opentest4j.AssertionFailedError: Got a non-empty set [Failed to send RPC 
RPC 4622017872898699852 to localhost/127.0.0.1:41507: 
io.netty.channel.unix.Errors$NativeIoException: send(..) failed with 
error(-32): Broken pipe] ==> expected: <true> but was: <false>, took 0.018s
   [error]     at 
org.apache.spark.network.RpcIntegrationSuite.assertErrorAndClosed(RpcIntegrationSuite.java:377)
   [error]     at 
org.apache.spark.network.RpcIntegrationSuite.sendRpcWithStreamFailures(RpcIntegrationSuite.java:332)
   [info] Test 
org.apache.spark.network.RpcIntegrationSuite#sendRpcWithStreamOneAtATime() 
started
   [info] Test 
org.apache.spark.network.RpcIntegrationSuite#sendSuccessAndFailure() started
   [info] Test run finished: 1 failed, 0 ignored, 10 total, 0.195s
   ```
   
   The root cause seems that one of the expected error message is 
[java.io.IOException Broken 
pipe](https://github.com/apache/spark/blob/edc7c96741c4382f79956f7ff5b9077e45f92014/common/network-common/src/test/java/org/apache/spark/network/RpcIntegrationSuite.java#L370)
 but the actual error message is ` 
io.netty.channel.unix.Errors$NativeIoException: send(..) failed with 
error(-32): Broken pipe`.
   
   Actually, the old Netty threw `IOException` directly but newer Netty wraps 
`IOException` in `NativeIOException`.
   
https://github.com/netty/netty/blob/5272df455afcd1cfae3e1156d6ac958a69fca32a/transport-native-unix-common/src/main/java/io/netty/channel/unix/Errors.java#L87
   
   ### Why are the changes needed?
   For test stability.
   
   ### Does this PR introduce _any_ user-facing change?
   No.
   
   ### How was this patch tested?
   Self code review. Let's see this issue no longer occurs on CI.
   
   ### Was this patch authored or co-authored using generative AI tooling?
   No.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to