cboumalh commented on code in PR #52883:
URL: https://github.com/apache/spark/pull/52883#discussion_r2713405895
##########
common/utils/src/main/resources/error/error-conditions.json:
##########
@@ -6158,13 +6164,7 @@
"message" : [
"Invalid call to <function>; only valid Theta sketch buffers are
supported as inputs (such as those produced by the `theta_sketch_agg`
function)."
],
- "sqlState" : "22546"
- },
- "THETA_INVALID_LG_NOM_ENTRIES" : {
Review Comment:
yes, only if the user is checking specifically for the error class such as
below and not just the exception class. Not sure if this may actually cause
issues to users given how specific it is, but we can revert it and add a
separate error just for Tuple if you think its worth it. I just thought why not
dedup some code here.
```
try {
// some sketch operation
} catch {
case e: SparkRuntimeException if e.getErrorClass ==
"SKETCH_INVALID_LG_NOM_ENTRIES" =>
...
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
