zhengruifeng commented on code in PR #53783:
URL: https://github.com/apache/spark/pull/53783#discussion_r2714983741
##########
python/pyspark/sql/connect/client/core.py:
##########
@@ -1433,6 +1434,7 @@ def handle_response(b: pb2.ExecutePlanResponse) -> None:
except Exception as error:
self._handle_error(error)
+ @disable_gc
def _execute_and_fetch_as_iterator(
Review Comment:
`_execute_and_fetch_as_iterator` and `_execute` are for `Execute` RPC, do
you think whether we need to disable other kinds of RPC (e.g. `_analyze` for
`Analyze` RPC)?
##########
python/pyspark/sql/connect/client/core.py:
##########
@@ -1433,6 +1434,7 @@ def handle_response(b: pb2.ExecutePlanResponse) -> None:
except Exception as error:
self._handle_error(error)
+ @disable_gc
def _execute_and_fetch_as_iterator(
Review Comment:
`_execute_and_fetch_as_iterator` and `_execute` are for `Execute` RPC, do
you think whether we need to disable GC in other kinds of RPC (e.g. `_analyze`
for `Analyze` RPC)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
