gaogaotiantian commented on code in PR #53925:
URL: https://github.com/apache/spark/pull/53925#discussion_r2719539717
##########
python/pyspark/pandas/groupby.py:
##########
@@ -1955,12 +1955,16 @@ def apply(self, func: Callable, *args: Any, **kwargs:
Any) -> Union[DataFrame, S
psdf, self._groupkeys, agg_columns
)
+ if LooseVersion(pd.__version__) < "3.0.0":
Review Comment:
Having a scheduled job is helpful but I don't think that should block us
from fixing the issues. We won't be able to get the CI result of running our
unmerged code with pandas 3 anyway. We should confirm that the new code still
works with pandas 2 and gradually make it compatible with pandas 3.
I don't believe the current scheduled CI would be super helpful because the
tests won't even run :) . They'll error out because we are trying to import a
non-exist function. Our test script stops when it gets an error so we won't be
able to see the whole picture either.
We should fix the obvious stuff quickly so we can get some useful
information from the scheduled CI job.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
