GitHub user a-roberts opened a pull request:

    https://github.com/apache/spark/pull/6740

    [SPARK-7756] CORE RDDOperationScope fix for IBM Java

    IBM Java has an extra method when we do getStackTrace(): this is 
"getStackTraceImpl", a native method. This causes two tests to fail within 
"DStreamScopeSuite" when running with IBM Java. Instead of "map" or "filter" 
being the method names found, "getStackTrace" is returned. This commit 
addresses such an issue by using dropWhile. Given that our current method is 
withScope, we look for the next method that isn't ours: we don't care about 
methods that come before us in the stack trace: e.g. getStackTrace (regardless 
of how many levels this might go).
    
    IBM:
    java.lang.Thread.getStackTraceImpl(Native Method)
    java.lang.Thread.getStackTrace(Thread.java:1117)
    
org.apache.spark.rdd.RDDOperationScope$.withScope(RDDOperationScope.scala:104)
    
    Oracle:
    PRINTING STACKTRACE!!!
    java.lang.Thread.getStackTrace(Thread.java:1552)
    
org.apache.spark.rdd.RDDOperationScope$.withScope(RDDOperationScope.scala:106)
    
    I've tested this with Oracle and IBM Java, no side effects for other tests 
introduced.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/a-roberts/spark RDDScopeStackCrawlFix

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/6740.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #6740
    
----
commit a4fc0e025d41d197c55ce43bca14ef669aa9bc68
Author: a-roberts <[email protected]>
Date:   2015-06-09T18:01:43Z

    Update RDDOperationScope.scala

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to