anishshri-db commented on code in PR #53930:
URL: https://github.com/apache/spark/pull/53930#discussion_r2724979312
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/RocksDBStateEncoder.scala:
##########
@@ -328,6 +331,39 @@ trait DataEncoder {
*/
def encodePrefixKeyForRangeScan(row: UnsafeRow): Array[Byte]
+ /**
+ * Encodes key and event time, ensuring prefix scan with key and also proper
sort order with
+ * event time within the same key in RocksDB.
+ *
+ * This method handles the encoding as follows:
+ * - Encodes the key columns normally and put them first
+ * - Appends the event time Long value in big-endian order as the last 8
bytes
+ *
+ * @param row An UnsafeRow denoting a key
+ * @param eventTime Long value representing the event time
+ * @return Serialized bytes that will maintain prefix scan with key and sort
order with
+ * event time
+ * @throws UnsupportedOperationException if called on an encoder that
doesn't support event time
+ * as postfix.
+ */
+ def encodeKeyForEventTimeAsPostfix(row: UnsafeRow, eventTime: Long):
Array[Byte]
Review Comment:
Could we make this more generic ? Don't think we should call out `eventTime`
as such - can just name it as `longType` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
