jonmio commented on code in PR #53820:
URL: https://github.com/apache/spark/pull/53820#discussion_r2725838922
##########
python/pyspark/sql/session.py:
##########
@@ -563,14 +563,14 @@ def getOrCreate(self) -> "SparkSession":
module.applyModifiableSettings(session._jsparkSession,
self._options)
return session
- # Spark Connect-specific API
- @remote_only
def create(self) -> "SparkSession":
Review Comment:
I think the `build(foreCreate: Boolean)` pattern works really well on the
Scala side within classic mode, but for the Python code we have to handle both
connect and classic and it seems like there is a bunch of complex handling for
each mode. IMO it would be even more confusing to put this all under one shared
function. Lmk if you have good ideas on how to make this code easier to reason
about though
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
