uros-db commented on code in PR #53227: URL: https://github.com/apache/spark/pull/53227#discussion_r2728666693
########## sql/catalyst/src/test/java/org/apache/spark/sql/catalyst/util/geo/WkbMultiGeometryTest.java: ########## @@ -0,0 +1,210 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.spark.sql.catalyst.util.geo; + +import org.junit.jupiter.api.Assertions; +import org.junit.jupiter.api.Test; + +import java.util.Arrays; +import java.util.List; + +/** + * Test suite for WKB multi-geometry types (MultiPoint, MultiLineString, MultiPolygon). + */ +public class WkbMultiGeometryTest extends WkbTestBase { + + @Test + public void testSimpleMultiPoint() { + // MULTIPOINT((0 0), (1 1), (2 2)) + List<Point> points = Arrays.asList( + new Point(new double[]{0.0, 0.0}, 0), + new Point(new double[]{1.0, 1.0}, 0), + new Point(new double[]{2.0, 2.0}, 0) + ); + MultiPoint multiPoint = new MultiPoint(points, 0, false, false); + + Assertions.assertFalse(multiPoint.isEmpty(), "MultiPoint should not be empty"); + Assertions.assertEquals(3, multiPoint.getNumGeometries(), "Number of geometries"); + Assertions.assertEquals(0.0, multiPoint.getPoints().get(0).getX(), 1e-10, "First point X"); + Assertions.assertEquals(1.0, multiPoint.getPoints().get(1).getX(), 1e-10, "Second point X"); + Assertions.assertEquals(2.0, multiPoint.getPoints().get(2).getX(), 1e-10, "Third point X"); + } + + @Test + public void testEmptyMultiPoint() { + // MULTIPOINT EMPTY + MultiPoint multiPoint = new MultiPoint(List.of(), 0, false, false); + + Assertions.assertTrue(multiPoint.isEmpty(), "MultiPoint should be empty"); + Assertions.assertEquals(0, multiPoint.getNumGeometries(), "Number of geometries should be 0"); + } + + @Test + public void testMultiPointRoundTrip() { + List<Point> points = Arrays.asList( + new Point(new double[]{1.0, 2.0}, 0), + new Point(new double[]{3.0, 4.0}, 0) + ); + MultiPoint original = new MultiPoint(points, 0, false, false); + + WkbWriter writer = new WkbWriter(); + byte[] wkb = writer.write(original); + + WkbReader reader = new WkbReader(); + GeometryModel parsed = reader.read(wkb, 0); + + Assertions.assertInstanceOf(MultiPoint.class, parsed, "Parsed geometry should be MultiPoint"); + MultiPoint parsedMP = (MultiPoint) parsed; + Assertions.assertEquals(original.getNumGeometries(), parsedMP.getNumGeometries(), + "Number of points should match"); + } + + @Test + public void testSimpleMultiLineString() { + // MULTILINESTRING((0 0, 1 1), (2 2, 3 3)) + List<Point> ls1Points = Arrays.asList( + new Point(new double[]{0.0, 0.0}, 0), + new Point(new double[]{1.0, 1.0}, 0) + ); + LineString ls1 = new LineString(ls1Points, 0, false, false); + + List<Point> ls2Points = Arrays.asList( + new Point(new double[]{2.0, 2.0}, 0), + new Point(new double[]{3.0, 3.0}, 0) + ); + LineString ls2 = new LineString(ls2Points, 0, false, false); + + MultiLineString multiLineString = new MultiLineString(Arrays.asList(ls1, ls2), 0, false, false); + + Assertions.assertFalse(multiLineString.isEmpty(), "MultiLineString should not be empty"); + Assertions.assertEquals(2, multiLineString.getNumGeometries(), "Number of geometries"); + } + + @Test + public void testEmptyMultiLineString() { + // MULTILINESTRING EMPTY + MultiLineString multiLineString = new MultiLineString(List.of(), 0, false, false); + + Assertions.assertTrue(multiLineString.isEmpty(), "MultiLineString should be empty"); + Assertions.assertEquals(0, multiLineString.getNumGeometries(), + "Number of geometries should be 0"); + } + + @Test + public void testMultiLineStringRoundTrip() { + List<Point> ls1Points = Arrays.asList( + new Point(new double[]{0.0, 0.0}, 0), + new Point(new double[]{1.0, 1.0}, 0) + ); + List<Point> ls2Points = Arrays.asList( + new Point(new double[]{2.0, 2.0}, 0), + new Point(new double[]{3.0, 3.0}, 0) + ); + MultiLineString original = new MultiLineString(Arrays.asList( + new LineString(ls1Points, 0, false, false), + new LineString(ls2Points, 0, false, false) + ), 0, false, false); + + WkbWriter writer = new WkbWriter(); + byte[] wkb = writer.write(original); + System.out.println("WKB hex: " + bytesToHex(wkb)); Review Comment: This looks like a leftover from prototyping? We should probably remove it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
