cloud-fan commented on PR #53570: URL: https://github.com/apache/spark/pull/53570#issuecomment-3803644809
Some high-level comments: 1. `SparkSessionExtensions` allows power users to register functions with `FunctionIdentifier`, which can include database and catalog names, in addition to the function name. We have very little control here, and I don't think the `extension` namespace can be applied. 2. The PR description does not mention the design sketch, shall we give one? The function registry is keyed by `FunctionIdentifier`, which already supports functions with same names, as long as they have different qualifier. So the design sketch can be: function names are always qualified before putting into the function registry. When lookup functions, we qualify the function name differently and try multiple times, according to the priority order. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
