Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/6735#discussion_r32102012
--- Diff: core/src/main/scala/org/apache/spark/util/ClosureCleaner.scala ---
@@ -109,7 +109,16 @@ private[spark] object ClosureCleaner extends Logging {
private def createNullValue(cls: Class[_]): AnyRef = {
if (cls.isPrimitive) {
- new java.lang.Byte(0: Byte) // Should be convertible to any
primitive type
+ if (cls == java.lang.Boolean.TYPE) {
--- End diff --
Can you use `match` syntax here?
I see why `boolean` needs a special case, but a `byte` widens to a `char`
in Java so I don't think that's necessary?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
