zhengruifeng commented on code in PR #54014:
URL: https://github.com/apache/spark/pull/54014#discussion_r2734529433
##########
sql/connect/common/src/main/scala/org/apache/spark/sql/connect/Dataset.scala:
##########
@@ -703,6 +703,16 @@ class Dataset[T] private[sql] (
}
}
+ /** @inheritdoc */
+ def zipWithIndex(indexColName: String): DataFrame = {
Review Comment:
since scala client is supported in this PR, we may want to add some tests in
src/test/scala/org/apache/spark/sql/PlanGenerationTestSuite.scala
org/apache/spark/sql/connect/ClientE2ETestSuite.scala
but the tests can be added in a followup PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
