fangchenli commented on code in PR #54000:
URL: https://github.com/apache/spark/pull/54000#discussion_r2734914252
##########
python/pyspark/pandas/tests/computation/test_combine.py:
##########
@@ -392,7 +464,7 @@ def test_merge_raises(self):
):
left.merge(right, left_on=["value", "x"], right_on="value")
- with self.assertRaisesRegex(ValueError, "['inner', 'left', 'right',
'full', 'outer']"):
+ with self.assertRaisesRegex(ValueError, "['inner', 'left', 'right',
'outer', 'cross']"):
Review Comment:
The error msg in `validate_how` was actually `"......['inner', 'left',
'right', 'outer']",` but the original error msg contains commas, and it got
rendered to something like this `("The 'how' parameter has to be...",
"['inner', ...]")
` Combine with the fact that we didn't escape the backslashes and didn't use
the r string, the test was passing accidentally.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
