uros-db commented on code in PR #54038:
URL: https://github.com/apache/spark/pull/54038#discussion_r2740457771
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/text/TextFileFormat.scala:
##########
@@ -142,7 +142,10 @@ case class TextFileFormat() extends TextBasedFileFormat
with DataSourceRegister
}
}
- override def supportDataType(dataType: DataType): Boolean =
- dataType.isInstanceOf[StringType]
+ override def supportDataType(dataType: DataType): Boolean = dataType match {
+ case _: GeometryType | _: GeographyType => false
Review Comment:
Makes sense, we don't really need these changes given the original
condition. Reverted.
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/text/TextTable.scala:
##########
@@ -46,7 +46,11 @@ case class TextTable(
}
}
- override def supportsDataType(dataType: DataType): Boolean = dataType ==
StringType
+ override def supportsDataType(dataType: DataType): Boolean = dataType match {
+ case _: GeometryType | _: GeographyType => false
Review Comment:
Done, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
