cloud-fan commented on code in PR #54034: URL: https://github.com/apache/spark/pull/54034#discussion_r2742211856
########## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/collect.scala: ########## @@ -54,6 +54,10 @@ abstract class Collect[T <: Growable[Any] with Iterable[Any]] extends TypedImper protected def convertToBufferElement(value: Any): Any + // Subclasses can override this to allow nulls in buffer + // (e.g., CollectList with ignoreNulls=false) + protected def bufferContainsNull: Boolean = false Review Comment: this base class has `override def dataType: DataType = ArrayType(child.dataType, false)`, shall we update it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
