szehon-ho commented on code in PR #54039:
URL: https://github.com/apache/spark/pull/54039#discussion_r2746601970
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetWriteSupport.scala:
##########
@@ -276,6 +276,20 @@ class ParquetWriteSupport extends
WriteSupport[InternalRow] with Logging {
(row: SpecializedGetters, ordinal: Int) =>
recordConsumer.addBinary(Binary.fromReusedByteArray(row.getBinary(ordinal)))
+ case _: GeometryType =>
+ (row: SpecializedGetters, ordinal: Int) =>
+ // Data is written to Parquet using the WKB format.
+ // WKB Spec: https://libgeos.org/specifications/wkb/.
Review Comment:
Nit: do we need this link to wkb spec?
If we do maybe we should also add the Parquet spec that specifies wkb:
https://parquet.apache.org/docs/file-format/types/geospatial/
But maybe we don't as its just repeated and the wkb spec makes more sense on
the reader?
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetWriteSupport.scala:
##########
@@ -276,6 +276,20 @@ class ParquetWriteSupport extends
WriteSupport[InternalRow] with Logging {
(row: SpecializedGetters, ordinal: Int) =>
recordConsumer.addBinary(Binary.fromReusedByteArray(row.getBinary(ordinal)))
+ case _: GeometryType =>
+ (row: SpecializedGetters, ordinal: Int) =>
+ // Data is written to Parquet using the WKB format.
+ // WKB Spec: https://libgeos.org/specifications/wkb/.
Review Comment:
Nit: do we need this link to wkb spec?
If we do maybe we should also add the Parquet spec that specifies wkb:
https://parquet.apache.org/docs/file-format/types/geospatial/
But maybe we don't as its just repeated and the wkb spec makes more sense on
the WkbReader?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
