anishshri-db commented on code in PR #53900:
URL: https://github.com/apache/spark/pull/53900#discussion_r2748637722
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/checkpointing/OffsetSeq.scala:
##########
@@ -361,6 +361,46 @@ object OffsetSeqControlBatchInfo {
private implicit val format: Formats = Serialization.formats(NoTypeHints)
}
+/**
+ * An offset type for Sequential Union operations, stored directly in the
offset log.
+ * Sequential Union enables seamless backfill-to-live streaming scenarios by
processing multiple
+ * sources sequentially rather than concurrently.
+ *
+ * This is stored as an entry in the offset map (just like source offsets),
allowing multiple
+ * sequential unions per query to each track their own state.
+ *
+ * All source tracking is name-based (not index-based) to ensure stability
across query restarts
+ * and to integrate with the query evolution feature.
+ *
+ * @param activeSourceName The name of the currently active source being
processed.
+ * @param completedSources Set of source names that have finished processing.
+ * @param sourceNames All source names in the order they should be processed.
Review Comment:
nit: should we rename as `allSourceNames` and `completedSourceNames` ?
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/checkpointing/OffsetSeq.scala:
##########
@@ -361,6 +361,46 @@ object OffsetSeqControlBatchInfo {
private implicit val format: Formats = Serialization.formats(NoTypeHints)
}
+/**
+ * An offset type for Sequential Union operations, stored directly in the
offset log.
+ * Sequential Union enables seamless backfill-to-live streaming scenarios by
processing multiple
+ * sources sequentially rather than concurrently.
+ *
+ * This is stored as an entry in the offset map (just like source offsets),
allowing multiple
+ * sequential unions per query to each track their own state.
+ *
+ * All source tracking is name-based (not index-based) to ensure stability
across query restarts
+ * and to integrate with the query evolution feature.
+ *
+ * @param activeSourceName The name of the currently active source being
processed.
+ * @param completedSources Set of source names that have finished processing.
+ * @param sourceNames All source names in the order they should be processed.
Review Comment:
Should we invert the order here ? `sourceNames` before the `completedOnes` ?
##########
sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/SequentialUnionOffsetSuite.scala:
##########
@@ -0,0 +1,161 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.sql.execution.streaming
+
+import org.apache.spark.SparkFunSuite
+import
org.apache.spark.sql.execution.streaming.checkpointing.SequentialUnionOffset
+
+class SequentialUnionOffsetSuite extends SparkFunSuite {
Review Comment:
lets add a class level comment for what the suite does ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
