mridulm commented on code in PR #53657:
URL: https://github.com/apache/spark/pull/53657#discussion_r2752654215
##########
core/src/test/resources/HistoryServerExpectations/application_list_json_expectation.json:
##########
@@ -5,6 +5,7 @@
"duration" : 2006,
"endTime" : "2025-12-27T14:15:12.221GMT",
"endTimeEpoch" : 1766844912221,
+ "exitCode" : 0,
Review Comment:
Any non-zero exit code case to test this change ?
##########
core/src/main/scala/org/apache/spark/ui/jobs/AllJobsPage.scala:
##########
@@ -342,6 +343,16 @@ private[ui] class AllJobsPage(parent: JobsTab, store:
AppStatusStore) extends We
}
}
</li>
+ {
+ exitCode match {
+ case Some(code) if code != 0 =>
Review Comment:
Instead of trying to interpret the exit code - which, as discussed below,
can be misleading for cases like pyspark.
Why not simply show what the exit code is, when available ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
