juliuszsompolski commented on PR #52399: URL: https://github.com/apache/spark/pull/52399#issuecomment-3834812294
It would be great to add some dedicated tests that check in the plan that WSCG triggered. Like @viirya mentioned, we if it codegens, we would also now be testing with codegen and not with no-codegen, but this is a general problem of all Spark SQL... @viirya do we have other places that re-test SparkSQL execution with and without codegen enabled? We could add a duplicated test suite, one enabling and one disabling codegen, though I don't see it being done in other places... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
