VindhyaG commented on code in PR #53383:
URL: https://github.com/apache/spark/pull/53383#discussion_r2757123419
##########
core/src/test/scala/org/apache/spark/storage/BlockManagerSuite.scala:
##########
@@ -129,6 +129,9 @@ class BlockManagerSuite extends SparkFunSuite with Matchers
with PrivateMethodTe
val bmConf = testConf.map(_.setAll(conf.getAll)).getOrElse(conf)
bmConf.set(TEST_MEMORY, maxMem)
bmConf.set(MEMORY_OFFHEAP_SIZE, maxMem)
+ if(maxMem > 0) {
+ bmConf.set(MEMORY_OFFHEAP_ENABLED, true)
Review Comment:
This is for the UTs wtih the tests where if maxMem set specifically
greather than 0 only then set the MEMORY_OFFHEAP_ENABLED to true else keep it
default false. Earlier MEMORY_OFFHEAP_ENABLED was always set to default false
and only MEMORY_OFFHEAP_SIZE value was used to test all the combinations
because earlier MEMORY_OFFHEAP_ENABLED true needed MEMORY_OFFHEAP_SIZE > 0 and
not vice versa. MEMORY_OFFHEAP_ENABLED value sort of did not matter at all. We
cannot do that with this change where if MEMORY_OFFHEAP_ENABLED is false
maxMem is essentially zero as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
