cloud-fan commented on code in PR #54137:
URL: https://github.com/apache/spark/pull/54137#discussion_r2764205644


##########
sql/core/src/test/resources/sql-tests/inputs/pivot.sql:
##########
@@ -298,3 +298,58 @@ PIVOT (
   sum(Earnings)
   FOR Course IN ('dotNET', 'Java')
 );
+
+-- pivot with alias
+SELECT pv.* FROM (
+  SELECT year, course, earnings FROM courseSales
+)
+PIVOT (
+  sum(earnings)
+  FOR course IN ('dotNET', 'Java')
+) AS pv;
+
+-- pivot with alias (without AS keyword)

Review Comment:
   nit: SQL golden file is for integration test. Tiny cases like this should go 
to unit test (which we already did and we can just remove this query here)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to