Github user liancheng commented on a diff in the pull request:

    https://github.com/apache/spark/pull/6686#discussion_r32122236
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/types/StructType.scala ---
    @@ -104,6 +104,67 @@ case class StructType(fields: Array[StructField]) 
extends DataType with Seq[Stru
       private lazy val nameToIndex: Map[String, Int] = 
fieldNames.zipWithIndex.toMap
     
       /**
    +   * Creates a new [[StructType]] by adding a new field.
    +   * {{{
    +   * val struct = (new StructType)
    +   *  .add(StructField("a", IntegerType, true))
    +   *  .add(StructField("b", LongType, false))
    +   *  .add(StructField("c", StringType, true))
    +   *}}}
    +   */
    +  def add(field: StructField): StructType = {
    +    StructType(fields :+ field)
    +  }
    +
    +  /**
    +   * Creates a new [[StructType]] by adding a new field.
    +   *
    +   * val struct = (new StructType)
    +   *  .add(StructField("a", IntegerType, true))
    +   *  .add(StructField("b", LongType, false))
    +   *  .add(StructField("c", StringType, true))
    +   */
    +  def add(name: String, dataType: DataType): StructType = {
    +    StructType(fields :+ new StructField(name, dataType, true, 
Metadata.empty))
    +  }
    +
    +  def add(name: String, dataType: DataType, nullable: Boolean): StructType 
= {
    +    StructType(fields :+ new StructField(name, dataType, nullable, 
Metadata.empty))
    +  }
    +
    +  def add(name: String,
    +    dataType: DataType,
    +    nullable: Boolean,
    +    metadata: Metadata): StructType = {
    --- End diff --
    
    BTW, are we intentionally avoiding default argument values for Java API 
friendliness here?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to