gengliangwang commented on PR #54134: URL: https://github.com/apache/spark/pull/54134#issuecomment-3856917280
Some general comments: * Performance: repeated heap indices serialization/deserialization per row (consider TypedImperativeAggregate) * Safety: no practical upper bound on k (risk of OOM) * Completeness: missing PySpark API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
