gaogaotiantian commented on code in PR #54085:
URL: https://github.com/apache/spark/pull/54085#discussion_r2771558645


##########
python/pyspark/sql/streaming/python_streaming_source_runner.py:
##########
@@ -116,6 +138,77 @@ def send_batch_func(
         write_int(EMPTY_PYARROW_RECORD_BATCHES, outfile)
 
 
+def check_support_func(reader: DataSourceStreamReader, outfile: IO) -> None:
+    support_flags = 0
+    if isinstance(reader, _SimpleStreamReaderWrapper):

Review Comment:
   Yeah that's one of my questions - do we need a symmetric implementation 
between scala and python? Or we just need API to match. I have not had the 
chance to look at the scala implementation.
   
   On the other hand, is this mixin public? That users can use directly? If so, 
merging this means we have to go with this method in the future right? To keep 
compatibility.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to