anishshri-db commented on code in PR #54083:
URL: https://github.com/apache/spark/pull/54083#discussion_r2772643566
##########
sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/state/RocksDBStateStoreSuite.scala:
##########
@@ -1730,7 +1730,19 @@ class RocksDBStateStoreSuite extends
StateStoreSuiteBase[RocksDBStateStoreProvid
}
}
- test("validate rocksdb values iterator correctness") {
+ private def testMergeWithOperatorVersions(testName: String)(testFn: Int =>
Unit): Unit = {
+ RocksDBConf.MERGE_OPERATOR_VALID_VERSIONS.foreach { version =>
+ test(testName + s" - merge operator version $version") {
+ withSQLConf(SQLConf.STATE_STORE_ROCKSDB_MERGE_OPERATOR_VERSION.key ->
version.toString) {
+ testFn(version)
+ }
+ }
+ }
+ }
+
+ testMergeWithOperatorVersions(
+ "validate rocksdb values iterator correctness - put then merge") { _ =>
+
Review Comment:
nit: extra newline ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
