terana commented on code in PR #52232:
URL: https://github.com/apache/spark/pull/52232#discussion_r2781832376
##########
sql/connect/server/src/main/scala/org/apache/spark/sql/connect/service/SparkConnectExecutionManager.scala:
##########
@@ -147,11 +157,12 @@ private[connect] class SparkConnectExecutionManager()
extends Logging {
// getting an INVALID_HANDLE.OPERATION_ABANDONED error on a retry.
if (abandoned) {
abandonedTombstones.put(key, executeHolder.getExecuteInfo)
+ executeHolder.sessionHolder.closeOperation(executeHolder.operationId)
Review Comment:
We call `closeOperation` here, and then almost immediately unconditionally
on the line 165. Is this intended? What difference does it make?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
