heyihong commented on code in PR #54056:
URL: https://github.com/apache/spark/pull/54056#discussion_r2782477014
##########
sql/connect/server/src/main/scala/org/apache/spark/sql/connect/service/ExecuteEventsManager.scala:
##########
@@ -275,16 +276,14 @@ case class ExecuteEventsManager(executeHolder:
ExecuteHolder, clock: Clock) {
validStatuses: List[ExecuteStatus],
eventStatus: ExecuteStatus): Unit = {
if (validStatuses.find(s => s == status).isEmpty) {
- throw new IllegalStateException(s"""
- operationId: $operationId with status ${status}
- is not within statuses $validStatuses for event $eventStatus
- """)
+ throw IllegalStateErrors.executionStateTransitionInvalid(
Review Comment:
You can simply pass the parameters and construct the messages inside the
methods.
##########
sql/connect/server/src/main/scala/org/apache/spark/sql/connect/service/ExecuteEventsManager.scala:
##########
@@ -275,16 +276,14 @@ case class ExecuteEventsManager(executeHolder:
ExecuteHolder, clock: Clock) {
validStatuses: List[ExecuteStatus],
eventStatus: ExecuteStatus): Unit = {
if (validStatuses.find(s => s == status).isEmpty) {
- throw new IllegalStateException(s"""
- operationId: $operationId with status ${status}
- is not within statuses $validStatuses for event $eventStatus
- """)
+ throw IllegalStateErrors.executionStateTransitionInvalid(
+ s"operationId: $operationId with status $status is not within " +
+ s"statuses $validStatuses for event $eventStatus")
}
if (sessionHolder.eventManager.status != SessionStatus.Started) {
- throw new IllegalStateException(s"""
- sessionId: $sessionId with status $sessionStatus
- is not Started for event $eventStatus
- """)
+ throw IllegalStateErrors.executionStateTransitionInvalid(
Review Comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
