sandip-db commented on code in PR #53857:
URL: https://github.com/apache/spark/pull/53857#discussion_r2784541238
##########
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/xml/parsers/StaxXmlGeneratorSuite.scala:
##########
@@ -50,21 +49,21 @@ final class StaxXmlGeneratorSuite extends
SharedSparkSession {
longDatum = 1520828868,
stringDatum = "test,breakdelimiter",
timeDatum = "12:34:56",
- timestampDatum = Timestamp.from(ZonedDateTime.of(2017, 12, 20, 21, 46,
54, 0,
- ZoneId.of("UTC")).toInstant),
+ timestampDatum = Timestamp.from(
+ ZonedDateTime.of(2017, 12, 20, 21, 46, 54, 0,
ZoneId.of("UTC")).toInstant),
nullDatum = null),
- KnownData(booleanDatum = false,
+ KnownData(
+ booleanDatum = false,
dateDatum = Date.valueOf("2016-12-19"),
decimalDatum = Decimal(12.345, 10, 3),
doubleDatum = 21.2121,
integerDatum = 34,
longDatum = 1520828123,
stringDatum = "breakdelimiter,test",
timeDatum = "23:45:16",
- timestampDatum = Timestamp.from(ZonedDateTime.of(2017, 12, 29, 17, 21,
49, 0,
- ZoneId.of("America/New_York")).toInstant),
- nullDatum = null)
- )
+ timestampDatum = Timestamp.from(
+ ZonedDateTime.of(2017, 12, 29, 17, 21, 49, 0,
ZoneId.of("America/New_York")).toInstant),
Review Comment:
Please undo these cosmetic changes. Easier to `git blame` for context.
##########
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/xml/parsers/StaxXmlGeneratorSuite.scala:
##########
@@ -75,4 +74,109 @@ final class StaxXmlGeneratorSuite extends
SharedSparkSession {
assert(df.collect().toSeq === newDf.collect().toSeq)
}
+ // SPARK-45414: Test for string tag content misplacement with mixed column
types
Review Comment:
SPARK-45414 was for spark-xml and not for Spark's built-in XML reader.
```suggestion
// SPARK-45414: Test for string tag content misplacement issue (found in
spark-xml library)
// with mixed column types
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
