pan3793 commented on code in PR #494:
URL:
https://github.com/apache/spark-kubernetes-operator/pull/494#discussion_r2786147217
##########
spark-operator/src/main/java/org/apache/spark/k8s/operator/SparkOperator.java:
##########
@@ -285,6 +285,7 @@ protected List<Interceptor>
getClientInterceptors(MetricsSystem metricsSystem) {
public static void main(String[] args) {
log.info("Version: {}",
SparkOperator.class.getPackage().getImplementationVersion());
log.info("Java Version: " + Runtime.version().toString());
+ log.info("Built-in Spark Version: " +
org.apache.spark.package$.MODULE$.SPARK_VERSION());
Review Comment:
generally, we prefer to use placeholder `{}` over `+` for slf4j, to avoid
unnecessary string construction overhead when log level threshold is higher.
```suggestion
log.info("Built-in Spark Version: {}",
org.apache.spark.package$.MODULE$.SPARK_VERSION());
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
